colgora/Mangarr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(manga): Chapter entité DDD de Manga + AggregateRoot

Browse Source 
- Ajoute AggregateRoot dans Shared (domain events + pull pattern)
- Manga extends AggregateRoot, devient vrai aggregate root DDD
- Chapter passe de readonly à entité mutable avec MangaId VO
- Manga expose les méthodes domaine pour toute mutation de chapitre :
  addChapter, updateChapterTitle/Volume/Pages, hideChapter, removeChapterPages
- Supprime saveChapter/updateChapter/deleteChapter de MangaRepositoryInterface
- save(Manga) gère désormais la persistance des chapitres via pull pattern
- Tous les handlers/listeners passent par l'agrégat (plus d'accès direct)
- phparkitect autorise AggregateRoot dans les couches Domain

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
ext.jeremy.guillot@maxicoffee.domains
2026-03-09 19:15:11 +01:00
parent a4b3d8a5f1
commit 2c051351a8
18 changed files with 226 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/Domain/Manga/Application/CommandHandler/DeleteCbzHandler.php
View File

@@ -7,8 +7,6 @@ use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Contract\Service\FileServiceInterface;
use App\Domain\Manga\Domain\Exception\ChapterNotFoundException;
use App\Domain\Manga\Domain\Exception\CbzFileNotFoundException;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Shared\Domain\Contract\CommandHandlerInterface;
use App\Domain\Shared\Domain\Contract\CommandInterface;
@@ -33,18 +31,8 @@ readonly class DeleteCbzHandler implements CommandHandlerInterface
throw new CbzFileNotFoundException($command->chapterId);
}
$updatedChapter = new Chapter(
new ChapterId($chapter->getId()),
$chapter->getMangaId(),
$chapter->getNumber(),
$chapter->getTitle(),
$chapter->getVolume(),
$chapter->isVisible(),
null,
0,
$chapter->getCreatedAt()
);
$this->mangaRepository->updateChapter($updatedChapter);
$manga = $this->mangaRepository->findById($chapter->getMangaId()->getValue());
$manga->removeChapterPages($chapter);
$this->mangaRepository->save($manga);
}
}

18
src/Domain/Manga/Application/CommandHandler/DeleteChapterHandler.php
View File

@@ -5,8 +5,6 @@ namespace App\Domain\Manga\Application\CommandHandler;
use App\Domain\Manga\Application\Command\DeleteChapter;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Exception\ChapterNotFoundException;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Shared\Domain\Contract\CommandHandlerInterface;
use App\Domain\Shared\Domain\Contract\CommandInterface;
@@ -26,18 +24,8 @@ readonly class DeleteChapterHandler implements CommandHandlerInterface
throw new ChapterNotFoundException($command->chapterId);
}
$updatedChapter = new Chapter(
id: new ChapterId($chapter->getId()),
mangaId: $chapter->getMangaId(),
number: $chapter->getNumber(),
title: $chapter->getTitle(),
volume: $chapter->getVolume(),
isVisible: false,
pagesDirectory: $chapter->getPagesDirectory(),
pageCount: $chapter->getPageCount(),
createdAt: $chapter->getCreatedAt()
);
$this->mangaRepository->updateChapter($updatedChapter);
$manga = $this->mangaRepository->findById($chapter->getMangaId()->getValue());
$manga->hideChapter($chapter);
$this->mangaRepository->save($manga);
}
}

8
src/Domain/Manga/Application/CommandHandler/EditMultipleChaptersHandler.php
View File

@@ -21,17 +21,17 @@ readonly class EditMultipleChaptersHandler
throw new ChapterNotFoundException($chapterData->id);
}
$updatedChapter = $chapter;
$manga = $this->mangaRepository->findById($chapter->getMangaId()->getValue());
if ($chapterData->title !== null) {
$updatedChapter = $updatedChapter->updateTitle($chapterData->title);
$manga->updateChapterTitle($chapter, $chapterData->title);
}
if ($chapterData->volume !== null) {
$updatedChapter = $updatedChapter->updateVolume($chapterData->volume);
$manga->updateChapterVolume($chapter, $chapterData->volume);
}
$this->mangaRepository->updateChapter($updatedChapter);
$this->mangaRepository->save($manga);
}
}
}

1
src/Domain/Manga/Application/CommandHandler/FetchMangaChaptersHandler.php
View File

@@ -29,5 +29,6 @@ readonly class FetchMangaChaptersHandler
// Synchronisation initiale (pas d'événements)
$this->chapterSynchronizationService->synchronizeChapters($manga);
$this->mangaRepository->save($manga);
}
}

21
src/Domain/Manga/Application/CommandHandler/ImportChapterHandler.php
View File

@@ -6,8 +6,6 @@ use App\Domain\Manga\Application\Command\ImportChapter;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Exception\MangaNotFoundException;
use App\Domain\Manga\Domain\Exception\ChapterNotFoundException;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Shared\Domain\Contract\MangaPathManagerInterface;
readonly class ImportChapterHandler
@@ -43,20 +41,9 @@ readonly class ImportChapterHandler
// 4. Save the CBZ file to storage using the path manager
$cbzPath = $this->saveCbzFile($command, $manga, $existingChapter);
// 5. Update existing chapter with new path
// Note: pagesDirectory holds CBZ path during transition; Phase 3 will store individual images
$updatedChapter = new Chapter(
id: new ChapterId($existingChapter->getId()),
mangaId: $existingChapter->getMangaId(),
number: $existingChapter->getNumber(),
title: $existingChapter->getTitle(),
volume: $existingChapter->getVolume(),
isVisible: $existingChapter->isVisible(),
pagesDirectory: $cbzPath,
pageCount: $existingChapter->getPageCount(),
createdAt: $existingChapter->getCreatedAt()
);
$this->mangaRepository->updateChapter($updatedChapter);
// 5. Update existing chapter with new path through the aggregate
$manga->updateChapterPages($existingChapter, $cbzPath, $existingChapter->getPageCount());
$this->mangaRepository->save($manga);
}
private function isValidCbzFile(string $fileBinary): bool
@@ -66,7 +53,7 @@ readonly class ImportChapterHandler
return strpos($fileBinary, $zipMagicNumber) === 0;
}
private function saveCbzFile(ImportChapter $command, \App\Domain\Manga\Domain\Model\Manga $manga, Chapter $chapter): string
private function saveCbzFile(ImportChapter $command, \App\Domain\Manga\Domain\Model\Manga $manga, \App\Domain\Manga\Domain\Model\Chapter $chapter): string
{
$volumeNumber = $chapter->getVolume() ?? 0;
$cbzPath = $this->pathManager->buildChapterCbzPath(

19
src/Domain/Manga/Application/CommandHandler/ImportVolumeHandler.php
View File

@@ -5,8 +5,6 @@ namespace App\Domain\Manga\Application\CommandHandler;
use App\Domain\Manga\Application\Command\ImportVolume;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Exception\MangaNotFoundException;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Shared\Domain\Contract\MangaPathManagerInterface;
readonly class ImportVolumeHandler
@@ -44,22 +42,11 @@ readonly class ImportVolumeHandler
// 4. Save the CBZ file to storage using the path manager
$cbzPath = $this->saveCbzFile($command, $manga);
// 5. Update all chapters with the volume path
// Note: pagesDirectory holds CBZ path during transition; Phase 3 will store individual images
// 5. Update all chapters with the volume path through the aggregate
foreach ($chapters as $chapter) {
$updatedChapter = new Chapter(
id: new ChapterId($chapter->getId()),
mangaId: $chapter->getMangaId(),
number: $chapter->getNumber(),
title: $chapter->getTitle(),
volume: $chapter->getVolume(),
isVisible: $chapter->isVisible(),
pagesDirectory: $cbzPath,
pageCount: $chapter->getPageCount(),
createdAt: $chapter->getCreatedAt()
);
$this->mangaRepository->updateChapter($updatedChapter);
$manga->updateChapterPages($chapter, $cbzPath, $chapter->getPageCount());
}
$this->mangaRepository->save($manga);
}
private function isValidCbzFile(string $fileBinary): bool

16
src/Domain/Manga/Application/EventListener/ChapterImportedEventListener.php
View File

@@ -5,8 +5,6 @@ declare(strict_types=1);
namespace App\Domain\Manga\Application\EventListener;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
use App\Domain\Shared\Domain\Event\ChapterImported;
@@ -26,18 +24,8 @@ readonly class ChapterImportedEventListener
$chapters = $this->mangaRepository->findVisibleChaptersByMangaIdAndVolume($manga->getId()->getValue(), (int) $event->volume);
foreach ($chapters as $chapter) {
if ($chapter->getNumber() === (float) $event->chapterNumber) {
$updated = new Chapter(
new ChapterId($chapter->getId()),
$chapter->getMangaId(),
$chapter->getNumber(),
$chapter->getTitle(),
$chapter->getVolume(),
$chapter->isVisible(),
$event->cbzPath,
$chapter->getPageCount(),
$chapter->getCreatedAt(),
);
$this->mangaRepository->updateChapter($updated);
$manga->updateChapterPages($chapter, $event->cbzPath, $chapter->getPageCount());
$this->mangaRepository->save($manga);
break;
}
}

16
src/Domain/Manga/Application/EventListener/VolumeImportedEventListener.php
View File

@@ -5,8 +5,6 @@ declare(strict_types=1);
namespace App\Domain\Manga\Application\EventListener;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
use App\Domain\Shared\Domain\Event\VolumeImported;
@@ -29,18 +27,8 @@ readonly class VolumeImportedEventListener
}
foreach ($chapters as $chapter) {
$updated = new Chapter(
new ChapterId($chapter->getId()),
$chapter->getMangaId(),
$chapter->getNumber(),
$chapter->getTitle(),
$chapter->getVolume(),
$chapter->isVisible(),
$event->cbzPath,
$chapter->getPageCount(),
$chapter->getCreatedAt(),
);
$this->mangaRepository->updateChapter($updated);
$manga->updateChapterPages($chapter, $event->cbzPath, $chapter->getPageCount());
}
$this->mangaRepository->save($manga);
}
}

10
src/Domain/Manga/Domain/Contract/Repository/MangaRepositoryInterface.php
View File

@@ -6,7 +6,6 @@ use App\Domain\Manga\Application\Query\MonitoringCriteria;
use App\Domain\Manga\Domain\Model\Manga;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\ValueObject\ExternalId;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
interface MangaRepositoryInterface
@@ -57,13 +56,4 @@ interface MangaRepositoryInterface
*/
public function findVisibleChaptersWithPagesByMangaIdAndVolume(string $mangaId, int $volume): array;
// --- Chapters (write) ---
/** Create a new chapter and return its generated ID. */
public function saveChapter(Chapter $chapter): ChapterId;
/** Update an existing chapter. */
public function updateChapter(Chapter $chapter): void;
public function deleteChapter(Chapter $chapter): void;
}

46
src/Domain/Manga/Domain/Model/Chapter.php
View File

@@ -3,12 +3,13 @@
namespace App\Domain\Manga\Domain\Model;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaId;
readonly class Chapter
class Chapter
{
public function __construct(
private ChapterId $id,
private string $mangaId,
private MangaId $mangaId,
private float $number,
private ?string $title,
private ?int $volume,
@@ -23,7 +24,7 @@ readonly class Chapter
return $this->id->getValue();
}
public function getMangaId(): string
public function getMangaId(): MangaId
{
return $this->mangaId;
}
@@ -68,33 +69,24 @@ readonly class Chapter
return $this->createdAt;
}
public function updateTitle(?string $title): self
public function updateTitle(?string $title): void
{
return new self(
$this->id,
$this->mangaId,
$this->number,
$title,
$this->volume,
$this->isVisible,
$this->pagesDirectory,
$this->pageCount,
$this->createdAt
);
$this->title = $title;
}
public function updateVolume(?int $volume): self
public function updateVolume(?int $volume): void
{
return new self(
$this->id,
$this->mangaId,
$this->number,
$this->title,
$volume,
$this->isVisible,
$this->pagesDirectory,
$this->pageCount,
$this->createdAt
);
$this->volume = $volume;
}
public function updatePagesDirectory(?string $pagesDirectory, int $pageCount = 0): void
{
$this->pagesDirectory = $pagesDirectory;
$this->pageCount = $pageCount;
}
public function hide(): void
{
$this->isVisible = false;
}
}

74
src/Domain/Manga/Domain/Model/Manga.php
View File

@@ -8,10 +8,20 @@ use App\Domain\Manga\Domain\Model\ValueObject\MangaId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
use App\Domain\Manga\Domain\Model\ValueObject\MangaTitle;
use App\Domain\Manga\Domain\Model\ValueObject\MonitoringStatus;
use App\Domain\Shared\Domain\Model\AggregateRoot;
use DateTimeImmutable;
final class Manga
final class Manga extends AggregateRoot
{
/** @var Chapter[] */
private array $newChapters = [];
/** @var array<string, Chapter> */
private array $modifiedChapters = [];
/** @var Chapter[] */
private array $chaptersToDelete = [];
public function __construct(
private MangaId $id,
private MangaTitle $title,
@@ -189,4 +199,66 @@ final class Manga
{
$this->lastMonitoringCheck = $lastMonitoringCheck;
}
public function addChapter(Chapter $chapter): void
{
$this->newChapters[] = $chapter;
}
public function updateChapterTitle(Chapter $chapter, ?string $title): void
{
$chapter->updateTitle($title);
$this->modifiedChapters[$chapter->getId()] = $chapter;
}
public function updateChapterVolume(Chapter $chapter, ?int $volume): void
{
$chapter->updateVolume($volume);
$this->modifiedChapters[$chapter->getId()] = $chapter;
}
public function updateChapterPages(Chapter $chapter, ?string $pagesDirectory, int $pageCount = 0): void
{
$chapter->updatePagesDirectory($pagesDirectory, $pageCount);
$this->modifiedChapters[$chapter->getId()] = $chapter;
}
public function hideChapter(Chapter $chapter): void
{
$chapter->hide();
$this->modifiedChapters[$chapter->getId()] = $chapter;
}
public function removeChapterPages(Chapter $chapter): void
{
$chapter->updatePagesDirectory(null, 0);
$this->modifiedChapters[$chapter->getId()] = $chapter;
}
/** @return Chapter[] */
public function pullNewChapters(): array
{
$chapters = $this->newChapters;
$this->newChapters = [];
return $chapters;
}
/** @return Chapter[] */
public function pullModifiedChapters(): array
{
$chapters = array_values($this->modifiedChapters);
$this->modifiedChapters = [];
return $chapters;
}
/** @return Chapter[] */
public function pullChaptersToDelete(): array
{
$chapters = $this->chaptersToDelete;
$this->chaptersToDelete = [];
return $chapters;
}
}

93
src/Domain/Manga/Infrastructure/Persistence/LegacyMangaRepository.php
View File

@@ -115,6 +115,44 @@ readonly class LegacyMangaRepository implements MangaRepositoryInterface
if ($entity->getId()) {
$manga->updateId(new MangaId((string) $entity->getId()));
}
// Handle new chapters added through the aggregate
foreach ($manga->pullNewChapters() as $chapter) {
$mangaEntity = $this->entityManager->find(EntityManga::class, (int) $manga->getId()->getValue());
$chapterEntity = new EntityChapter();
$chapterEntity->setManga($mangaEntity)
->setNumber($chapter->getNumber())
->setTitle($chapter->getTitle())
->setVolume($chapter->getVolume())
->setVisible($chapter->isVisible())
->setPagesDirectory($chapter->getPagesDirectory())
->setPageCount($chapter->getPageCount());
$this->entityManager->persist($chapterEntity);
}
// Handle chapters modified through the aggregate
foreach ($manga->pullModifiedChapters() as $chapter) {
$chapterEntity = $this->entityManager->find(EntityChapter::class, $chapter->getId());
if ($chapterEntity) {
$chapterEntity->setVisible($chapter->isVisible())
->setPagesDirectory($chapter->getPagesDirectory())
->setPageCount($chapter->getPageCount())
->setTitle($chapter->getTitle())
->setVolume($chapter->getVolume())
->setCbzPath($chapter->getPagesDirectory());
$this->entityManager->persist($chapterEntity);
}
}
// Handle chapters deleted through the aggregate
foreach ($manga->pullChaptersToDelete() as $chapter) {
$chapterEntity = $this->entityManager->find(EntityChapter::class, $chapter->getId());
if ($chapterEntity) {
$this->entityManager->remove($chapterEntity);
}
}
$this->entityManager->flush();
}
public function delete(DomainManga $manga): void
@@ -166,29 +204,6 @@ readonly class LegacyMangaRepository implements MangaRepositoryInterface
return $entity ? $this->toDomain($entity) : null;
}
public function saveChapter(Chapter $chapter): ChapterId
{
$manga = $this->entityManager->find(EntityManga::class, $chapter->getMangaId());
if (!$manga) {
throw new \RuntimeException('Manga not found');
}
$entity = new EntityChapter();
$entity->setManga($manga)
->setNumber($chapter->getNumber())
->setTitle($chapter->getTitle())
->setVolume($chapter->getVolume())
->setVisible($chapter->isVisible())
->setPagesDirectory($chapter->getPagesDirectory())
->setPageCount($chapter->getPageCount());
$this->entityManager->persist($entity);
$this->entityManager->flush();
return new ChapterId((string) $entity->getId());
}
public function findChapterById(string $id): ?Chapter
{
$entity = $this->entityManager->find(EntityChapter::class, $id);
@@ -226,36 +241,6 @@ readonly class LegacyMangaRepository implements MangaRepositoryInterface
return $entity ? $this->toChapterDomain($entity) : null;
}
public function updateChapter(Chapter $chapter): void
{
$entity = $this->entityManager->find(EntityChapter::class, $chapter->getId());
if (!$entity) {
throw new \RuntimeException(sprintf('Chapter with id %s not found', $chapter->getId()));
}
$entity->setVisible($chapter->isVisible())
->setPagesDirectory($chapter->getPagesDirectory())
->setPageCount($chapter->getPageCount())
->setTitle($chapter->getTitle())
->setVolume($chapter->getVolume())
// Keep cbzPath in sync during transition (Phase 4 will drop this column)
->setCbzPath($chapter->getPagesDirectory());
$this->entityManager->persist($entity);
$this->entityManager->flush();
}
public function deleteChapter(Chapter $chapter): void
{
$entity = $this->entityManager->find(EntityChapter::class, $chapter->getId());
if ($entity) {
$this->entityManager->remove($entity);
$this->entityManager->flush();
}
}
public function findChaptersByMangaIdAndVolume(string $mangaId, int $volume): array
{
$entities = $this->entityManager->getRepository(EntityChapter::class)
@@ -417,7 +402,7 @@ readonly class LegacyMangaRepository implements MangaRepositoryInterface
{
return new Chapter(
id: new ChapterId((string) $entity->getId()),
mangaId: (string) $entity->getManga()->getId(),
mangaId: new MangaId((string) $entity->getManga()->getId()),
number: $entity->getNumber(),
title: $entity->getTitle(),
volume: $entity->getVolume(),

6
src/Domain/Manga/Infrastructure/Service/MangadxChapterSynchronizationService.php
View File

@@ -67,7 +67,7 @@ readonly class MangadxChapterSynchronizationService implements ChapterSynchroniz
if ($shouldReplaceChapter) {
$chaptersByNumber[(string) $chapterNumber] = new Chapter(
new ChapterId((string) Uuid::uuid4()),
$manga->getId()->getValue(),
$manga->getId(),
$chapterNumber,
$title,
isset($chapterData['attributes']['volume']) ? (int) $chapterData['attributes']['volume'] : null,
@@ -98,8 +98,8 @@ readonly class MangadxChapterSynchronizationService implements ChapterSynchroniz
// Sauvegarde uniquement les nouveaux chapitres et collecte leurs IDs
foreach ($chaptersByNumber as $chapterNumber => $chapter) {
if (!isset($existingChapters[(float) $chapterNumber])) {
$newChapterId = $this->mangaRepository->saveChapter($chapter);
$newChapterIds[] = $newChapterId->getValue(); // ✨ Collecte des IDs
$manga->addChapter($chapter);
$newChapterIds[] = $chapter->getId();
}
}

21
src/Domain/Shared/Domain/Model/AggregateRoot.php Normal file
View File

@@ -0,0 +1,21 @@
<?php
namespace App\Domain\Shared\Domain\Model;
abstract class AggregateRoot
{
private array $domainEvents = [];
protected function recordEvent(object $event): void
{
$this->domainEvents[] = $event;
}
public function pullDomainEvents(): array
{
$events = $this->domainEvents;
$this->domainEvents = [];
return $events;
}
}