feat: GetChapters endpoint + tests

This commit is contained in:
ext.jeremy.guillot@maxicoffee.domains
2025-02-10 20:07:24 +01:00
parent 2f615a4936
commit 6667cc224b
15 changed files with 601 additions and 0 deletions

View File

@@ -3,12 +3,17 @@
namespace App\Tests\Domain\Manga\Adapter;
use App\Domain\Manga\Domain\Contract\Repository\MangaRepositoryInterface;
use App\Domain\Manga\Domain\Model\Chapter;
use App\Domain\Manga\Domain\Model\Manga;
use App\Domain\Manga\Domain\Model\ValueObject\ChapterId;
class InMemoryMangaRepository implements MangaRepositoryInterface
{
/** @var Manga[] */
private array $mangas = [];
/** @var array<string, Chapter[]> */
private array $chapters = [];
public function findAll(int $page = 1, int $limit = 20, string $sortBy = 'title', string $sortOrder = 'asc'): array
{
@@ -66,8 +71,49 @@ class InMemoryMangaRepository implements MangaRepositoryInterface
};
}
public function findChapters(string $mangaId, int $page = 1, int $limit = 20, string $sortOrder = 'desc'): array
{
if (!isset($this->chapters[$mangaId])) {
return [];
}
$chapters = $this->chapters[$mangaId];
usort($chapters, function (Chapter $a, Chapter $b) use ($sortOrder) {
return $sortOrder === 'desc'
? $b->getNumber() <=> $a->getNumber()
: $a->getNumber() <=> $b->getNumber();
});
$offset = ($page - 1) * $limit;
return array_slice($chapters, $offset, $limit);
}
public function countChapters(string $mangaId): int
{
return isset($this->chapters[$mangaId]) ? count($this->chapters[$mangaId]) : 0;
}
public function addChaptersToManga(string $mangaId, int $count): void
{
$this->chapters[$mangaId] = [];
for ($i = 1; $i <= $count; $i++) {
$this->chapters[$mangaId][] = new Chapter(
id: new ChapterId((string)$i),
mangaId: $mangaId,
number: (float)$i,
title: "Chapter $i",
volume: (int)ceil($i / 10),
isVisible: true,
createdAt: new \DateTimeImmutable()
);
}
}
public function clear(): void
{
$this->mangas = [];
$this->chapters = [];
}
}

View File

@@ -0,0 +1,104 @@
<?php
namespace App\Tests\Domain\Manga\Application\QueryHandler;
use App\Domain\Manga\Application\Query\GetMangaChapters;
use App\Domain\Manga\Application\QueryHandler\GetMangaChaptersHandler;
use App\Domain\Manga\Domain\Exception\MangaNotFoundException;
use App\Domain\Manga\Domain\Model\Manga;
use App\Domain\Manga\Domain\Model\ValueObject\MangaId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
use App\Domain\Manga\Domain\Model\ValueObject\MangaTitle;
use App\Tests\Domain\Manga\Adapter\InMemoryMangaRepository;
use PHPUnit\Framework\TestCase;
class GetMangaChaptersHandlerTest extends TestCase
{
private InMemoryMangaRepository $repository;
private GetMangaChaptersHandler $handler;
protected function setUp(): void
{
$this->repository = new InMemoryMangaRepository();
$this->handler = new GetMangaChaptersHandler($this->repository);
}
public function testHandleThrowsExceptionWhenMangaNotFound(): void
{
$this->expectException(MangaNotFoundException::class);
$query = new GetMangaChapters('non-existent-id');
$this->handler->handle($query);
}
public function testHandleReturnsEmptyListWhenNoChapters(): void
{
// Arrange
$this->givenMangaExists('123');
// Act
$query = new GetMangaChapters('123');
$response = $this->handler->handle($query);
// Assert
$this->assertEmpty($response->chapters);
$this->assertEquals(0, $response->total);
$this->assertEquals(1, $response->page);
$this->assertEquals(20, $response->limit);
$this->assertFalse($response->hasNextPage());
$this->assertFalse($response->hasPreviousPage());
}
public function testHandleReturnsPaginatedChapters(): void
{
// Arrange
$this->givenMangaExistsWithChapters('123', 25);
// Act
$query = new GetMangaChapters('123', page: 2, limit: 10);
$response = $this->handler->handle($query);
// Assert
$this->assertCount(10, $response->chapters);
$this->assertEquals(25, $response->total);
$this->assertEquals(2, $response->page);
$this->assertEquals(10, $response->limit);
$this->assertTrue($response->hasNextPage());
$this->assertTrue($response->hasPreviousPage());
}
protected function tearDown(): void
{
$this->repository->clear();
}
private function givenMangaExists(string $id): void
{
$manga = $this->createManga($id);
$this->repository->save($manga);
}
private function givenMangaExistsWithChapters(string $id, int $chapterCount): void
{
$this->givenMangaExists($id);
// Note: We'll need to implement this in InMemoryMangaRepository
$this->repository->addChaptersToManga($id, $chapterCount);
}
private function createManga(string $id): Manga
{
return new Manga(
id: new MangaId($id),
title: new MangaTitle('Test Manga'),
slug: new MangaSlug('test-manga'),
description: 'This is a test manga',
author: 'Test Author',
publicationYear: 2024,
genres: ['Action', 'Adventure'],
status: 'Ongoing',
externalId: null,
imageUrl: null,
rating: null
);
}
}

View File

@@ -0,0 +1,115 @@
<?php
namespace App\Tests\Feature\Manga;
use App\Entity\Chapter;
use App\Entity\Manga;
use App\Tests\Feature\AbstractApiTestCase;
use Zenstruck\Foundry\Test\ResetDatabase;
class GetMangaChaptersTest extends AbstractApiTestCase
{
use ResetDatabase;
public function testGetChaptersOfNonExistentManga(): void
{
// When
$client = static::createClient();
$response = $client->request('GET', '/api/mangas/999/chapters');
// Then
$this->assertResponseStatusCodeSame(404);
}
public function testGetEmptyChapterList(): void
{
// Given
$manga = $this->createManga();
// When
$client = static::createClient();
$response = $client->request('GET', '/api/mangas/' . $manga->getId() . '/chapters');
// Then
$this->assertResponseIsSuccessful();
$this->assertJsonContains([
'total' => 0,
'page' => 1,
'limit' => 20,
'hasNextPage' => false,
'hasPreviousPage' => false,
'items' => []
]);
}
public function testGetChaptersWithPagination(): void
{
// Given
$manga = $this->createManga();
$this->createChapters($manga, 25);
// When
$client = static::createClient();
$response = $client->request('GET', '/api/mangas/' . $manga->getId() . '/chapters', [
'query' => [
'page' => 2,
'limit' => 10,
'sortOrder' => 'desc'
]
]);
// Then
$this->assertResponseIsSuccessful();
$data = $response->toArray();
$this->assertCount(10, $data['items']);
$this->assertEquals(25, $data['total']);
$this->assertEquals(2, $data['page']);
$this->assertEquals(10, $data['limit']);
$this->assertTrue($data['hasNextPage']);
$this->assertTrue($data['hasPreviousPage']);
$numbers = array_map(fn($item) => $item['number'], $data['items']);
$expectedNumbers = $numbers;
rsort($expectedNumbers);
$this->assertEquals($expectedNumbers, $numbers);
}
private function createManga(): Manga
{
$manga = new Manga();
$manga->setTitle('One Piece')
->setSlug('one-piece')
->setDescription('Test description')
->setAuthor('Eiichiro Oda')
->setPublicationYear(1997)
->setGenres(['action', 'adventure'])
->setStatus('ongoing')
->setMonitored(true);
$entityManager = static::getContainer()->get('doctrine')->getManager();
$entityManager->persist($manga);
$entityManager->flush();
return $manga;
}
private function createChapters(Manga $manga, int $count): void
{
$entityManager = static::getContainer()->get('doctrine')->getManager();
for ($i = 1; $i <= $count; $i++) {
$chapter = new Chapter();
$chapter->setManga($manga)
->setNumber($i)
->setTitle("Chapter $i")
->setVolume((int)ceil($i / 10))
->setVisible(true);
$entityManager->persist($chapter);
}
$entityManager->flush();
}
}