colgora/Mangarr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: ajout de la fonctionnalité d'édition des mangas, incluant la création d'un modal d'édition, la mise à jour de l'API pour gérer les modifications, et l'intégration de la logique de gestion des erreurs. Tests ajoutés pour valider le bon fonctionnement de l'édition.

Browse Source
This commit is contained in:
ext.jeremy.guillot@maxicoffee.domains
2025-06-30 20:00:09 +02:00
parent 896c57ac34
commit 9255509042
20 changed files with 1185 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

170
tests/Domain/Manga/Application/CommandHandler/EditMangaHandlerTest.php Normal file
View File

@@ -0,0 +1,170 @@
<?php
namespace App\Tests\Domain\Manga\Application\CommandHandler;
use App\Domain\Manga\Application\Command\EditManga;
use App\Domain\Manga\Application\CommandHandler\EditMangaHandler;
use App\Domain\Manga\Domain\Exception\MangaNotFoundException;
use App\Domain\Manga\Domain\Model\Manga;
use App\Domain\Manga\Domain\Model\ValueObject\ExternalId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaId;
use App\Domain\Manga\Domain\Model\ValueObject\MangaSlug;
use App\Domain\Manga\Domain\Model\ValueObject\MangaTitle;
use App\Tests\Domain\Manga\Adapter\InMemoryMangaRepository;
use PHPUnit\Framework\TestCase;
class EditMangaHandlerTest extends TestCase
{
private InMemoryMangaRepository $repository;
private EditMangaHandler $handler;
protected function setUp(): void
{
$this->repository = new InMemoryMangaRepository();
$this->handler = new EditMangaHandler($this->repository);
}
public function testHandleEditMangaSuccess(): void
{
// Given - Create a manga first
$manga = new Manga(
new MangaId('manga-123'),
new MangaTitle('One Piece'),
new MangaSlug('one-piece'),
'Original description',
'Eiichiro Oda',
1997,
['action', 'adventure'],
'ongoing',
new ExternalId('external-123'),
'http://example.com/image.jpg',
4.5,
null,
['op']
);
$this->repository->save($manga);
// When - Edit the manga
$command = new EditManga(
id: 'manga-123',
title: 'One Piece Updated',
description: 'Updated description',
author: 'Eiichiro Oda Updated',
publicationYear: 1998,
genres: ['action', 'adventure', 'comedy'],
status: 'completed',
rating: 4.8,
alternativeSlugs: ['onepiece', 'op', 'luffy']
);
$this->handler->handle($command);
// Then - Verify the manga was updated
$updatedManga = $this->repository->findById('manga-123');
$this->assertNotNull($updatedManga);
$this->assertEquals('One Piece Updated', $updatedManga->getTitle()->getValue());
$this->assertEquals('Updated description', $updatedManga->getDescription());
$this->assertEquals('Eiichiro Oda Updated', $updatedManga->getAuthor());
$this->assertEquals(1998, $updatedManga->getPublicationYear());
$this->assertEquals(['action', 'adventure', 'comedy'], $updatedManga->getGenres());
$this->assertEquals('completed', $updatedManga->getStatus());
$this->assertEquals(4.8, $updatedManga->getRating());
$this->assertEquals(['onepiece', 'op', 'luffy'], $updatedManga->getAlternativeSlugs());
}
public function testHandleEditMangaPartialUpdate(): void
{
// Given - Create a manga first
$manga = new Manga(
new MangaId('manga-123'),
new MangaTitle('One Piece'),
new MangaSlug('one-piece'),
'Original description',
'Eiichiro Oda',
1997,
['action', 'adventure'],
'ongoing',
new ExternalId('external-123'),
'http://example.com/image.jpg',
4.5,
null,
['op']
);
$this->repository->save($manga);
// When - Edit only title and rating
$command = new EditManga(
id: 'manga-123',
title: 'One Piece - Updated Title Only',
rating: 4.9
);
$this->handler->handle($command);
// Then - Verify only specified fields were updated
$updatedManga = $this->repository->findById('manga-123');
$this->assertNotNull($updatedManga);
$this->assertEquals('One Piece - Updated Title Only', $updatedManga->getTitle()->getValue());
$this->assertEquals(4.9, $updatedManga->getRating());
// Original values should remain unchanged
$this->assertEquals('Original description', $updatedManga->getDescription());
$this->assertEquals('Eiichiro Oda', $updatedManga->getAuthor());
$this->assertEquals(1997, $updatedManga->getPublicationYear());
$this->assertEquals(['action', 'adventure'], $updatedManga->getGenres());
$this->assertEquals('ongoing', $updatedManga->getStatus());
$this->assertEquals(['op'], $updatedManga->getAlternativeSlugs());
}
public function testHandleEditMangaNotFound(): void
{
// When - Try to edit non-existent manga
$command = new EditManga(
id: 'non-existent-id',
title: 'Updated Title'
);
// Then
$this->expectException(MangaNotFoundException::class);
$this->handler->handle($command);
}
public function testHandleEditAlternativeSlugsSeparately(): void
{
// Given - Create a manga first
$manga = new Manga(
new MangaId('manga-123'),
new MangaTitle('One Piece'),
new MangaSlug('one-piece'),
'Original description',
'Eiichiro Oda',
1997,
['action', 'adventure'],
'ongoing',
new ExternalId('external-123'),
'http://example.com/image.jpg',
4.5,
null,
['op', 'onepiece']
);
$this->repository->save($manga);
// When - Edit only alternativeSlugs
$command = new EditManga(
id: 'manga-123',
alternativeSlugs: ['luffy-manga', 'pirate-king', 'one-piece-manga']
);
$this->handler->handle($command);
// Then - Verify only alternativeSlugs was updated
$updatedManga = $this->repository->findById('manga-123');
$this->assertNotNull($updatedManga);
$this->assertEquals(['luffy-manga', 'pirate-king', 'one-piece-manga'], $updatedManga->getAlternativeSlugs());
// All other fields should remain unchanged
$this->assertEquals('One Piece', $updatedManga->getTitle()->getValue());
$this->assertEquals('Original description', $updatedManga->getDescription());
}
}

174
tests/Feature/Manga/EditMangaTest.php Normal file
View File

@@ -0,0 +1,174 @@
<?php
namespace App\Tests\Feature\Manga;
use App\Tests\Feature\AbstractApiTestCase;
use Zenstruck\Foundry\Test\ResetDatabase;
class EditMangaTest extends AbstractApiTestCase
{
use ResetDatabase;
public function testEditMangaSuccess(): void
{
// Given - Create a manga first
$client = static::createClient();
$response = $client->request('POST', '/api/mangas/create', [
'json' => [
'title' => 'One Piece',
'slug' => 'one-piece',
'description' => 'Original description',
'author' => 'Eiichiro Oda',
'publicationYear' => 1997,
'genres' => ['action', 'adventure'],
'status' => 'ongoing',
'externalId' => 'external-123',
'imageUrl' => 'http://example.com/image.jpg',
'rating' => 4.5
]
]);
$this->assertResponseIsSuccessful();
// Get the created manga ID from database
$entityManager = static::getContainer()->get('doctrine')->getManager();
$createdManga = $entityManager->getRepository(\App\Entity\Manga::class)->findOneBy(['slug' => 'one-piece']);
$this->assertNotNull($createdManga);
$mangaId = $createdManga->getId();
// When - Edit the manga
$response = $client->request('PUT', '/api/mangas/' . $mangaId . '/edit', [
'json' => [
'title' => 'One Piece Updated',
'description' => 'Updated description',
'author' => 'Eiichiro Oda Updated',
'publicationYear' => 1998,
'genres' => ['action', 'adventure', 'comedy'],
'status' => 'completed',
'rating' => 4.8,
'alternativeSlugs' => ['onepiece', 'op']
]
]);
// Then
$this->assertResponseIsSuccessful();
// Verify the manga was updated in database
$entityManager = static::getContainer()->get('doctrine')->getManager();
$manga = $entityManager->getRepository(\App\Entity\Manga::class)->find($mangaId);
$this->assertNotNull($manga);
$this->assertEquals('One Piece Updated', $manga->getTitle());
$this->assertEquals('Updated description', $manga->getDescription());
$this->assertEquals('Eiichiro Oda Updated', $manga->getAuthor());
$this->assertEquals(1998, $manga->getPublicationYear());
$this->assertEquals(['action', 'adventure', 'comedy'], $manga->getGenres());
$this->assertEquals('completed', $manga->getStatus());
$this->assertEquals(4.8, $manga->getRating());
$this->assertEquals(['onepiece', 'op'], $manga->getAlternativeSlugs());
}
public function testEditMangaWithInvalidData(): void
{
// Given - Create a manga first
$client = static::createClient();
$response = $client->request('POST', '/api/mangas/create', [
'json' => [
'title' => 'One Piece 2',
'slug' => 'one-piece-2',
'description' => 'Original description',
'author' => 'Eiichiro Oda',
'publicationYear' => 1997,
'genres' => ['action', 'adventure'],
'status' => 'ongoing'
]
]);
$this->assertResponseIsSuccessful();
// Get the created manga ID from database
$entityManager = static::getContainer()->get('doctrine')->getManager();
$createdManga = $entityManager->getRepository(\App\Entity\Manga::class)->findOneBy(['slug' => 'one-piece-2']);
$this->assertNotNull($createdManga);
$mangaId = $createdManga->getId();
// When - Try to edit with invalid data
$client->request('PUT', '/api/mangas/' . $mangaId . '/edit', [
'json' => [
'title' => '', // Invalid: empty title
'publicationYear' => 2200, // Invalid: year > 2100
'genres' => [], // Invalid: empty genres
'status' => 'invalid-status', // Invalid status
'rating' => 6.0 // Invalid: rating > 5
]
]);
// Then
$this->assertResponseStatusCodeSame(422);
}
public function testEditMangaNotFound(): void
{
// When - Try to edit non-existent manga
$client = static::createClient();
$client->request('PUT', '/api/mangas/9999999/edit', [
'json' => [
'title' => 'Updated Title'
]
]);
// Then
$this->assertResponseStatusCodeSame(404);
}
public function testEditMangaPartialUpdate(): void
{
// Given - Create a manga first
$client = static::createClient();
$response = $client->request('POST', '/api/mangas/create', [
'json' => [
'title' => 'One Piece 3',
'slug' => 'one-piece-3',
'description' => 'Original description',
'author' => 'Eiichiro Oda',
'publicationYear' => 1997,
'genres' => ['action', 'adventure'],
'status' => 'ongoing',
'rating' => 4.5
]
]);
$this->assertResponseIsSuccessful();
// Get the created manga ID from database
$entityManager = static::getContainer()->get('doctrine')->getManager();
$createdManga = $entityManager->getRepository(\App\Entity\Manga::class)->findOneBy(['slug' => 'one-piece-3']);
$this->assertNotNull($createdManga);
$mangaId = $createdManga->getId();
// When - Edit only title and rating
$client->request('PUT', '/api/mangas/' . $mangaId . '/edit', [
'json' => [
'title' => 'One Piece - Updated Title Only',
'rating' => 4.9
]
]);
// Then
$this->assertResponseIsSuccessful();
// Verify only specified fields were updated
$entityManager = static::getContainer()->get('doctrine')->getManager();
$manga = $entityManager->getRepository(\App\Entity\Manga::class)->find($mangaId);
$this->assertNotNull($manga);
$this->assertEquals('One Piece - Updated Title Only', $manga->getTitle());
$this->assertEquals(4.9, $manga->getRating());
// Original values should remain unchanged
$this->assertEquals('Original description', $manga->getDescription());
$this->assertEquals('Eiichiro Oda', $manga->getAuthor());
$this->assertEquals(1997, $manga->getPublicationYear());
$this->assertEquals(['action', 'adventure'], $manga->getGenres());
$this->assertEquals('ongoing', $manga->getStatus());
}
}

6
tests/Feature/Reader/GetChapterContextTest.php
View File

@@ -24,18 +24,24 @@ final class GetChapterContextTest extends AbstractApiTestCase
'manga' => $manga,
'title' => 'Chapter 1',
'number' => 1,
'visible' => true,
'cbzPath' => '/path/to/chapter1.cbz',
]);
$chapter2 = ChapterFactory::createOne([
'manga' => $manga,
'title' => 'Chapter 2',
'number' => 2,
'visible' => true,
'cbzPath' => '/path/to/chapter2.cbz',
]);
$chapter3 = ChapterFactory::createOne([
'manga' => $manga,
'title' => 'Chapter 3',
'number' => 3,
'visible' => true,
'cbzPath' => '/path/to/chapter3.cbz',
]);
// Act