colgora/Mangarr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feature/upgrade-symfony-8 #35

Merged
colgora merged 4 commits from feature/upgrade-symfony-8 into main 2026-03-26 18:23:13 +01:00
Conversation 0 Commits 4 Files Changed 373 +92 -5
6 changed files with 92 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 69c6757cf8 - Show all commits

13
assets/vue/app/domain/setting/presentation/components/ContentSourceForm.vue
View File

@@ -242,8 +242,17 @@ watch(() => props.source, (newSource) => {
}
}, { immediate: true });
const buildPayload = (formData) => {
const data = { ...formData };
const raw = data.testChapterNumber;
data.testChapterNumber = (raw === '' || raw === null || raw === undefined)
? null
: parseFloat(raw);
return data;
};
const handleSubmit = () => {
emit('submit', { ...form.value });
emit('submit', buildPayload(form.value));
};
defineExpose({ submitForm: handleSubmit });
@@ -252,7 +261,7 @@ const testConfiguration = async () => {
testing.value = true;
try {
await emit('test', {
configuration: { ...form.value },
configuration: buildPayload(form.value),
testData: {
mangaSlug: form.value.testSlug,
chapterNumber: form.value.testChapterNumber,

4
config/reference.php
View File

@@ -1834,8 +1834,8 @@ use Symfony\Component\Config\Loader\ParamConfigurator as Param;
* }
* @psalm-type MercureConfig = array{
* hubs?: array<string, array{ // Default: []
* url?: scalar|Param|null, // URL of the hub's publish endpoint
* public_url?: scalar|Param|null, // URL of the hub's public endpoint // Default: null
* url?: scalar|Param|null, // URL of the hub's publish endpoint // Default: null
* public_url?: scalar|Param|null, // URL of the hub's public endpoint
* jwt?: string|array{ // JSON Web Token configuration.
* value?: scalar|Param|null, // JSON Web Token to use to publish to this hub.
* provider?: scalar|Param|null, // The ID of a service to call to provide the JSON Web Token.

2
src/Domain/Setting/Infrastructure/ApiPlatform/Resource/UpsertContentSourceResource.php
View File

@@ -16,6 +16,7 @@ use Symfony\Component\Validator\Constraints as Assert;
uriTemplate: '/content-sources',
processor: UpsertContentSourceStateProcessor::class,
input: UpsertContentSourceResource::class,
collectDenormalizationErrors: true,
status: 201,
description: 'Crée une nouvelle source de contenu'
),
@@ -24,6 +25,7 @@ use Symfony\Component\Validator\Constraints as Assert;
provider: GetContentSourceStateProvider::class,
processor: UpsertContentSourceStateProcessor::class,
input: UpsertContentSourceResource::class,
collectDenormalizationErrors: true,
description: 'Met à jour une source de contenu existante'
),
]

2
src/Entity/ContentSource.php
View File

@@ -73,7 +73,7 @@ class ContentSource
return $this->imageSelector;
}
public function setImageSelector(string $imageSelector): static
public function setImageSelector(?string $imageSelector): static
{
$this->imageSelector = $imageSelector;

31
tests/Feature/Setting/CreateContentSourceTest.php
View File

@@ -181,4 +181,35 @@ final class CreateContentSourceTest extends AbstractApiTestCase
$this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
}
public function testItAcceptsTestChapterNumberAsFloat(): void
{
$response = static::createClient()->request('POST', '/api/content-sources', [
'json' => [
'baseUrl' => 'https://mangadex.org',
'chapterUrlFormat' => 'https://mangadex.org/chapter/{id}',
'scrapingType' => 'html',
'testSlug' => 'one-piece',
'testChapterNumber' => 1.5,
],
]);
$this->assertResponseStatusCodeSame(Response::HTTP_CREATED);
}
public function testItRejectsTestChapterNumberAsEmptyStringWith422(): void
{
// Cas réel du formulaire Vue : le champ vide envoie "" au lieu de null.
// Doit retourner 422 (erreur de validation) et non 400 (données malformées).
$response = static::createClient()->request('POST', '/api/content-sources', [
'json' => [
'baseUrl' => 'https://mangadex.org',
'chapterUrlFormat' => 'https://mangadex.org/chapter/{id}',
'scrapingType' => 'html',
'testChapterNumber' => '',
],
]);
$this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
}
}

45
tests/Feature/Setting/UpdateContentSourceTest.php
View File

@@ -188,4 +188,49 @@ final class UpdateContentSourceTest extends AbstractApiTestCase
$this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
}
public function testItAcceptsTestChapterNumberAsFloat(): void
{
$response = static::createClient()->request('PUT', "/api/content-sources/{$this->sourceId}", [
'json' => [
'baseUrl' => 'https://mangadex.org',
'chapterUrlFormat' => 'https://mangadex.org/chapter/{id}',
'scrapingType' => 'html',
'testSlug' => 'one-piece',
'testChapterNumber' => 1.5,
],
]);
$this->assertResponseIsSuccessful();
}
public function testItAcceptsTestChapterNumberAsNull(): void
{
$response = static::createClient()->request('PUT', "/api/content-sources/{$this->sourceId}", [
'json' => [
'baseUrl' => 'https://mangadex.org',
'chapterUrlFormat' => 'https://mangadex.org/chapter/{id}',
'scrapingType' => 'html',
'testChapterNumber' => null,
],
]);
$this->assertResponseIsSuccessful();
}
public function testItRejectsTestChapterNumberAsEmptyStringWith422(): void
{
// Cas réel du formulaire Vue : le champ vide envoie "" au lieu de null.
// Doit retourner 422 (erreur de validation) et non 400 (données malformées).
$response = static::createClient()->request('PUT', "/api/content-sources/{$this->sourceId}", [
'json' => [
'baseUrl' => 'https://mangadex.org',
'chapterUrlFormat' => 'https://mangadex.org/chapter/{id}',
'scrapingType' => 'html',
'testChapterNumber' => '',
],
]);
$this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
}
}