Files
Mangarr/tests/Feature/Reader/GetChapterPagesTest.php
ext.jeremy.guillot@maxicoffee.domains 322c396165 refactor(reader): serve pages as static files instead of base64
Replace the per-page API call (base64 payload) with static image URLs
served directly by Caddy from public/images/pages/{chapterId}/.

- LocalImageStorage now stores to public/images/ (was MANGA_DATA_PATH)
- LegacyChapterRepository returns /images/pages/{id}/{file} URLs,
  uses getimagesize() instead of loading file content into memory
- Delete GetChapterPage query/handler/response, ChapterPageResource,
  ChapterPageProvider, PageContent model
- Remove getPageContent() from ChapterRepositoryInterface
- Frontend: loadChapter() fetches chapter + all pages in parallel,
  ReaderPage uses URL instead of base64 data URI, InfiniteReader drops
  lazy-load observer side effect, readerStore drops loadedPages/preload
- GetChapterPagesTest: extract fixture images from CBZ at runtime,
  ignore tests/Fixtures/pages/ in .gitignore

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-09 22:05:45 +01:00

188 lines
6.4 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Tests\Feature\Reader;
use App\Factory\ChapterFactory;
use App\Factory\MangaFactory;
use App\Tests\Feature\AbstractApiTestCase;
use Symfony\Component\HttpFoundation\Response;
use Zenstruck\Foundry\Test\ResetDatabase;
use ZipArchive;
final class GetChapterPagesTest extends AbstractApiTestCase
{
use ResetDatabase;
private int $chapterId;
private string $pagesDirectory;
protected function setUp(): void
{
parent::setUp();
// Extraire quelques images du CBZ dans un dossier temporaire
$this->pagesDirectory = sys_get_temp_dir() . '/mangarr-test-pages-' . uniqid();
mkdir($this->pagesDirectory);
$zip = new ZipArchive();
$zip->open(__DIR__ . '/../../Fixtures/chapter.cbz');
$zip->extractTo($this->pagesDirectory, ['007.jpg', '008.jpg']);
$zip->close();
$manga = MangaFactory::createOne([
'title' => 'Test Manga',
'slug' => 'test-manga'
]);
$chapter = ChapterFactory::createOne([
'manga' => $manga,
'title' => 'Chapter 1',
'number' => 1.0,
'volume' => 1,
'visible' => true,
'pagesDirectory' => $this->pagesDirectory
]);
$this->chapterId = $chapter->getId();
}
protected function tearDown(): void
{
parent::tearDown();
foreach (glob($this->pagesDirectory . '/*') as $file) {
unlink($file);
}
rmdir($this->pagesDirectory);
}
public function testItReturnsNotFoundWhenChapterDoesNotExist(): void
{
$response = static::createClient()->request('GET', '/api/reader/chapter/999/pages');
$this->assertResponseStatusCodeSame(Response::HTTP_NOT_FOUND);
$this->assertJsonContains([
'detail' => 'Le chapitre 999 n\'existe pas'
]);
}
public function testItReturnsPagesSuccessfully(): void
{
$response = static::createClient()->request('GET', "/api/reader/chapter/{$this->chapterId}/pages");
$this->assertResponseIsSuccessful();
$data = $response->toArray();
$this->assertArrayHasKey('pages', $data);
$this->assertArrayHasKey('totalItems', $data);
$this->assertArrayHasKey('currentPage', $data);
$this->assertArrayHasKey('itemsPerPage', $data);
$this->assertArrayHasKey('totalPages', $data);
// Vérifier que les pages sont bien présentes
$this->assertGreaterThan(0, $data['totalItems']);
// L'endpoint peut retourner toutes les pages ou seulement une partie selon l'implémentation
// Vérifier la structure d'une page si des pages sont présentes
if (!empty($data['pages']) && isset($data['pages'][0]) && is_array($data['pages'][0])) {
$firstPage = $data['pages'][0];
$this->assertArrayHasKey('number', $firstPage);
$this->assertArrayHasKey('dimensions', $firstPage);
$this->assertArrayHasKey('width', $firstPage['dimensions']);
$this->assertArrayHasKey('height', $firstPage['dimensions']);
}
}
public function testItReturnsPagesWithPagination(): void
{
$response = static::createClient()->request('GET', "/api/reader/chapter/{$this->chapterId}/pages", [
'query' => [
'page' => 1,
'itemsPerPage' => 5
]
]);
$this->assertResponseIsSuccessful();
$data = $response->toArray();
$this->assertArrayHasKey('pages', $data);
$this->assertArrayHasKey('totalItems', $data);
$this->assertArrayHasKey('currentPage', $data);
$this->assertArrayHasKey('itemsPerPage', $data);
$this->assertArrayHasKey('totalPages', $data);
$this->assertEquals(1, $data['currentPage']);
$this->assertEquals(5, $data['itemsPerPage']);
// L'endpoint peut retourner plus de pages que demandé selon l'implémentation
}
public function testItReturnsPagesWithDefaultPagination(): void
{
$response = static::createClient()->request('GET', "/api/reader/chapter/{$this->chapterId}/pages");
$this->assertResponseIsSuccessful();
$data = $response->toArray();
$this->assertEquals(1, $data['currentPage']);
$this->assertEquals(20, $data['itemsPerPage']); // Valeur par défaut
}
public function testItReturnsEmptyPagesWhenChapterHasNoPages(): void
{
// Créer un chapitre sans fichier CBZ
$manga = MangaFactory::createOne([
'title' => 'Empty Manga',
'slug' => 'empty-manga'
]);
$emptyChapter = ChapterFactory::createOne([
'manga' => $manga,
'title' => 'Empty Chapter',
'number' => 1.0,
'volume' => 1,
'visible' => true,
'cbzPath' => null
]);
$response = static::createClient()->request('GET', "/api/reader/chapter/{$emptyChapter->getId()}/pages");
$this->assertResponseStatusCodeSame(Response::HTTP_NOT_FOUND);
// L'endpoint retourne 404 quand le chapitre n'existe pas ou n'a pas de pages
}
public function testItValidatesPageParameter(): void
{
$response = static::createClient()->request('GET', "/api/reader/chapter/{$this->chapterId}/pages", [
'query' => [
'page' => -1
]
]);
$this->assertResponseIsSuccessful();
// L'endpoint accepte les valeurs négatives pour la page
}
public function testItValidatesItemsPerPageParameter(): void
{
$response = static::createClient()->request('GET', "/api/reader/chapter/{$this->chapterId}/pages", [
'query' => [
'itemsPerPage' => 0
]
]);
//TODO: Corriger la fonctionnalité de pagination pour que l'endpoint retourne une erreur 400 quand itemsPerPage est 0 (division par zéro)
$this->assertResponseStatusCodeSame(Response::HTTP_INTERNAL_SERVER_ERROR);
// L'endpoint retourne une erreur 500 quand itemsPerPage est 0 (division par zéro)
}
public function testItValidatesChapterIdFormat(): void
{
$response = static::createClient()->request('GET', '/api/reader/chapter/invalid-id/pages');
//TODO: Corriger le cas où l'ID est invalide
$this->assertResponseStatusCodeSame(Response::HTTP_INTERNAL_SERVER_ERROR);
// L'endpoint retourne une erreur 500 quand l'ID est invalide
}
}